Skip to content

Commit

Permalink
remove manually adding sslmode to connection string (#558)
Browse files Browse the repository at this point in the history
  • Loading branch information
dimberman authored and ahmelsayed committed Jan 23, 2020
1 parent 1b38a7f commit 39a496f
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pkg/scalers/postgres_scaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ func parsePostgresMetadata(resolvedEnv, metadata, authParams map[string]string)
}

if val, ok := authParams["connStr"]; ok {
meta.connStr = val + "?sslmode=disable"
meta.connStr = val
} else if val, ok := metadata["connStr"]; ok {
hostSetting := val

if val, ok := resolvedEnv[hostSetting]; ok {
meta.connStr = val + "?sslmode=disable"
meta.connStr = val
}
} else {
meta.connStr = ""
Expand Down Expand Up @@ -161,13 +161,11 @@ func (s *postGRESScaler) IsActive(ctx context.Context) (bool, error) {

func (s *postGRESScaler) getActiveNumber() (int, error) {
var id int
postgresLog.Info(fmt.Sprintf("Inspecting with query: %s", s.metadata.query))
err := s.connection.QueryRow(s.metadata.query).Scan(&id)
if err != nil {
postgresLog.Error(err, fmt.Sprintf("could not query PG: %s", err))
return 0, fmt.Errorf("could not query PG: %s", err)
}
postgresLog.Info(fmt.Sprintf("Num expected: %d", id))
return id, nil
}

Expand Down

0 comments on commit 39a496f

Please sign in to comment.