ClusterTriggerAuthentication to support headers so that accountId can be passed for NewRelic Scaler via authenticationRef

[pragmaticivan]

Proposal

apiVersion: keda.sh/v1alpha1
kind: ClusterTriggerAuthentication
metadata:
  name: newrelic
spec:
  secretTargetRef:
  - parameter: account
    name: keda-newrelic-creds
    key: account-number
  - parameter: queryKey
    name: keda-newrelic-creds
    key: api-key

Use-Case

Have multiple New Relic accounts and want to be able to set, apiKey, account number and region in the cluster authentication so developers don't need to care about that.

This would also help with NewRelic promql, which requires an api-key in different ways.

Anything else?

No response

[pragmaticivan]

account is currently required by the CRD, so I'm not sure if that currently works.

[pragmaticivan]

Perhaps it should be optional when not using trigger authentication.

[JorTurFer]

hey @pragmaticivan
Sorry for the slow response...
It sounds totally reasonable. In fact, I have checked the code and it's not documented in keda.sh but I'd say that the region can be passed by TriggerAuthentication (based on the code).
Are you open to contribute with this?

[pragmaticivan]

@JorTurFer It can easily be passed by using the function GetFromAuthOrMeta instead of the existing code. The region seems to be already handling that correctly.

[JorTurFer]

Yes, you should use that function instead of current code (like it's already done in region and key) and that's all.
Adding one test case and updating the docs are the only other task to do

[pragmaticivan]

Done!
#2898
kedacore/keda-docs#744