Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEDA operator crashes on nil memory panic if the eventhub connectionstring for Azure Eventhub Scaler contains an invalid character #3082

Closed
christle opened this issue May 30, 2022 · 2 comments · Fixed by #3080
Assignees
Labels
bug Something isn't working

Comments

@christle
Copy link
Contributor

christle commented May 30, 2022

Report

The Azure Eventhub Scaler creates a storage path with url.parse() based on information from an eventhub connection string. If this connection string contains invalid characters like newline, the url.parse raise an error. This error is unhandled, so the operator crashes with a panic.

Invalid characters usually appear if the connectionstring contains an incorrect base64 encoding.

Expected Behavior

the Azure Eventhub Scaler should log an error message, which contains informations about the incorrect connectionstring

Actual Behavior

the keda operator get a panic

Steps to Reproduce the Problem

  1. add an Azure Eventhub scaler
  2. add an Azure Eventhub connectionstring with a newline character
  3. the keda operator crash with a panic

Logs from KEDA operator

No response

KEDA Version

2.7.1

Kubernetes Version

No response

Platform

No response

Scaler Details

Eventhub Scaler

Anything else?

No response

@christle christle added the bug Something isn't working label May 30, 2022
@zroubalik zroubalik changed the title Keda operator crashes on nil memory panic if the eventhub connectionstring for eventhub scaler contains an invalid character KEDA operator crashes on nil memory panic if the eventhub connectionstring for Azure Eventhub Scaler contains an invalid character May 30, 2022
@v-shenoy
Copy link
Contributor

v-shenoy commented Jun 3, 2022

Should this be closed after #3080?

@zroubalik
Copy link
Member

Fixed in #3080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants