Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent operator from panic on invalid characters within Azure Eventhub-Storage path #3080

Merged
merged 1 commit into from
May 31, 2022
Merged

prevent operator from panic on invalid characters within Azure Eventhub-Storage path #3080

merged 1 commit into from
May 31, 2022

Conversation

christle
Copy link
Contributor

@christle christle commented May 30, 2022 •
edited by zroubalik
Loading

Hello,

we facing an issue with a crashing keda operator if the storage path of the eventhub scaler contains invalid characters. In our case, this happened with a wrong encoded base64 secret.

this change prevents the operator from crashing The url.parse provide a valid readable error message with enough details for debugging, so I did not add additional information on it.

Fixes: #3082

@christle christle requested a review from a team as a code owner May 30, 2022 07:09
JorTurFer
JorTurFer reviewed May 30, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Could you update the changelog? 🙏

zroubalik
zroubalik reviewed May 30, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for the contribution.

We should also open an issue for this, so it can be referenced in the Changelog

@christle
Copy link
Contributor Author

fix #3082

@christle
Copy link
Contributor Author

should i make a changelog entry within this PR?

@JorTurFer
Copy link
Member

should i make a changelog entry within this PR?

yes please, create an entry referring the issue 🙏

@zroubalik zroubalik changed the title prevent operator from panic on invalid characters within eventhub-storage path prevent operator from panic on invalid characters within Azure Eventhub-Storage path May 30, 2022
@zroubalik
Copy link
Member

zroubalik commented May 30, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progres here

@christle christle force-pushed the master branch 2 times, most recently from 479343c to 1d4e317 Compare May 31, 2022 05:45
@christle
prevent operator from panic on invalid characters within eventhub-sto…
28e4e84 
…rage path

Signed-off-by: Christian Leinweber <christian.leinweber@maibornwolff.de>
@christle
Copy link
Contributor Author

done

zroubalik
zroubalik approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@zroubalik zroubalik merged commit af28b7b into kedacore:main May 31, 2022
@v-shenoy v-shenoy mentioned this pull request Jun 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
ok-to-merge
Projects
None yet
Milestone
No milestone
3 participants
@christle @JorTurFer @zroubalik