Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate apiHost & host for RabbitMQ scaler #711

Closed
tomkerkhove opened this issue Mar 31, 2020 · 7 comments
Closed

Consolidate apiHost & host for RabbitMQ scaler #711

tomkerkhove opened this issue Mar 31, 2020 · 7 comments
Labels
breaking-change enhancement New feature or request
Milestone
v2.0

Comments

@tomkerkhove
Copy link
Member

Consolidate apiHost & host for RabbitMQ scaler.

Seperation was introduced via #700
@tomkerkhove tomkerkhove added needs-discussion feature-request All issues for new features that have not been committed to breaking-change labels Mar 31, 2020
@tomkerkhove tomkerkhove added this to the v2.0 milestone Mar 31, 2020
@tomkerkhove tomkerkhove added enhancement New feature or request and removed feature-request All issues for new features that have not been committed to needs-discussion labels Mar 31, 2020
@turbaszek
Copy link
Contributor

Do I correctly understand that providing host means that the scaler will use AMQP protocol and providing apiHost means using HTTP? If that's true should we consolidate those two params into a single host argument and add protocol param?

@tomkerkhove
Copy link
Member Author

Yes, that's the goal indeed so that it provides a more consistent experience. Are you willing to contribute this?

@turbaszek
Copy link
Contributor

I can take a look at this one as it would be wise to do this before 2.0. Are we ok with making this a breaking change?

@zroubalik
Copy link
Member

That's great, a breaking change is fine for me. (before 2.0 of course 😄)

turbaszek added a commit to turbaszek/keda that referenced this issue Sep 8, 2020
@turbaszek
Consolidate apiHost & host for RabbitMQ scaler
87fc84b 
closes kedacore#711

Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
@turbaszek turbaszek mentioned this issue Sep 8, 2020
Merged
4 tasks
turbaszek added a commit to turbaszek/keda that referenced this issue Sep 9, 2020
@turbaszek
Consolidate apiHost & host for RabbitMQ scaler
2330458 
closes kedacore#711

Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
turbaszek added a commit to turbaszek/keda that referenced this issue Sep 10, 2020
@turbaszek
Consolidate apiHost & host for RabbitMQ scaler
d779177 
closes kedacore#711

Signed-off-by: Tomek Urbaszek <tomasz.urbaszek@polidea.com>
@tomkerkhove
Copy link
Member Author

Re-opening for docs

@tomkerkhove tomkerkhove reopened this Sep 11, 2020
@turbaszek
Copy link
Contributor

@tomkerkhove should we close it as kedacore/keda-docs#253 was merged?

@tomkerkhove
Copy link
Member Author

Yes, sorry!

SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023
@cynthia-sg
Provide dedicated page per authentication provider (kedacore#867)
f7557f7 
* Provide dedicated page per authentication provider

This PR splits the `Authentication Providers` documentation page content into
multiple pages. A dedicated page per authentication provider has been added,
and the main page now includes a list of the available providers with a link to
each page. This change has been applied to versions 2.7 and 2.8.

Fixes kedacore#711

Signed-off-by: Cintia Sanchez Garcia <cynthiasg@icloud.com>

* Address feedback

Signed-off-by: Cintia Sanchez Garcia <cynthiasg@icloud.com>

* Add outlined class to providers buttons

Signed-off-by: Cintia Sanchez Garcia <cynthiasg@icloud.com>

* Address feedback

Signed-off-by: Cintia Sanchez Garcia <cynthiasg@icloud.com>

* Revert blank line deleted by mistake

Signed-off-by: Cintia Sanchez Garcia <cynthiasg@icloud.com>

* Add like to landing page

Signed-off-by: Cintia Sanchez Garcia <cynthiasg@icloud.com>

Signed-off-by: Cintia Sanchez Garcia <cynthiasg@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
3 participants
@zroubalik @tomkerkhove @turbaszek