Wrong aws_iam_authorization access key id setting #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierGeerinck
requested review from
ahmelsayed and
zroubalik
as code owners
zroubalik
reviewed
Nov 16, 2020
When getting the ACCESS_KEY_ID for AWS from Environment variables (which is currently the only working option), the `aws_iam_authorization` scaler would check if metadata.awsAccessKeyIDFromEnv was set, but it would then utilize the metadata.awsAccessKeyId for the name... while in the secretAccessKey it would then use the `FromEnv` one. This fixes that Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
XavierGeerinck
force-pushed
the
patch-1
branch
from
05e51d3
to
9402686
Compare
Done! Going to become a pro in this DCO signing 😂😅 thanks! |
|
One more thing, could you please add this PR to the changelog? (Unreleased, Thanks a lot for doing this! |
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
XavierGeerinck
force-pushed
the
patch-1
branch
from
037233e
to
9a07fe5
Compare
zroubalik
reviewed
Nov 16, 2020
Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>
zroubalik
approved these changes
Nov 16, 2020
arschles
pushed a commit
to arschles/keda
that referenced
this pull request
Dec 1, 2020
* Wrong aws_iam_authorization access key id setting When getting the ACCESS_KEY_ID for AWS from Environment variables (which is currently the only working option), the `aws_iam_authorization` scaler would check if metadata.awsAccessKeyIDFromEnv was set, but it would then utilize the metadata.awsAccessKeyId for the name... while in the secretAccessKey it would then use the `FromEnv` one. This fixes that Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com> Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the ACCESS_KEY_ID for AWS from Environment variables (which is currently the only working option), the
aws_iam_authorizationscaler would check if metadata.awsAccessKeyIDFromEnv was set, but it would then utilize the metadata.awsAccessKeyId for the name... while in the secretAccessKey it would then use theFromEnvone. This fixes thatProvide a description of what has been changed
Checklist
Fixes #