Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When fetching the pod data for a known core Kind, use a typed client request instead of Unstructured #1457

Merged
merged 6 commits into from
Jan 6, 2021
Merged

When fetching the pod data for a known core Kind, use a typed client request instead of Unstructured #1457

merged 6 commits into from
Jan 6, 2021

Commits on Dec 28, 2020

  1. When fetching the pod data for a known core Kind, use a typed client … 

    …request instead of Unstructured. This allows those requests to hit the informer cache while Unstructured gets cannot.

If controller-runtime adds support for reading Unstructured gets from the cache, this could be reverted in the future. This also adds the permissions required for setting up watches.

Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
    @coderanger
    coderanger committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    e1d6935 View commit details
    Browse the repository at this point in the history

  2. Fix controller-gen syntax. 

    Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
    @coderanger
    coderanger committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    7f90783 View commit details
    Browse the repository at this point in the history

  3. Update changelog. 

    Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
    @coderanger
    coderanger committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    aca76f0 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Replace reflect magic with a direct implementation for Deployment and… 

    … StatefulSet.

These are the only two core types which can be scaled anyway and this code is much less likely to break at runtime in unexpected ways.

Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
    @coderanger
    coderanger committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    b70c077 View commit details
    Browse the repository at this point in the history

  2. Only request cache permissions for Deployments and StatefulSets. 

    These should be the only two types that are needed with it, so minimal permissions are nice.

Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
    @coderanger
    coderanger committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    1c43c8b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into less-unstructured-get

    @coderanger
    coderanger committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    a8b5943 View commit details
    Browse the repository at this point in the history