Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cron scaler to parse the cron with parser instead of searching for '-' #2038

Merged
merged 5 commits into from
Aug 20, 2021
Merged

Update cron scaler to parse the cron with parser instead of searching for '-' #2038

merged 5 commits into from
Aug 20, 2021

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Aug 17, 2021 •
edited
Loading

Signed-off-by: jorturfer jorge_turrado@hotmail.es

This PR changes the method to validate the cron. Now the package parser is used to detect invalid expressions instead a custom method.

Checklist

Fixes #2034

@JorTurFer JorTurFer mentioned this pull request Aug 17, 2021
Merged
1 task
@zroubalik zroubalik added this to the v2.5.0 milestone Aug 18, 2021
zroubalik
zroubalik approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JorTurFer
Update cron job to parse the cron with parser
32585db 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer
Update the CHANGELOG
edbf3b9 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer
Fit the supported cron format to 'standard Linux cron'
19b8913 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer
Fix style
881144b 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

I have just rebased main into this branch to add integrate the changes

@zroubalik zroubalik merged commit c370c05 into kedacore:main Aug 20, 2021
@JorTurFer JorTurFer deleted the cron_scaler branch August 20, 2021 10:07
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
@JorTurFer @ahmelsayed @nilayasiktoprak
Update cron scaler to parse the cron with parser instead of searching…
80d6098 
… for '-' (kedacore#2038)

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>

Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@trondhindenes trondhindenes mentioned this pull request Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

Cron trigger does not support valid ranges
3 participants
@JorTurFer @ahmelsayed @zroubalik