fix: update graphite e2e test to generate empty metric #2954
Conversation
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
|
/run-e2e graphite* |
Oops on breaking e2e. |
{{ message }}
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkerkhove
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es
After this PR the graphite e2e test is broken (sorry, I forgot to trigger e2e tests). Even though the behaviour is correct, our e2e test doesn't update the metric to 0, only stops sending it (in my really short experience with graphite, it's not the real scenario).
The e2e test is based on the "null as zero" behaviour, and that's why it fails.
This PR adds another job to continue registering the metric with 0 value, simulating the real behaviour to allow the scale in and fix the e2e test.
Am I right @bpinske ?
Checklist
Fixes #2944