Fix: panic in datadog scaler #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vflaux
force-pushed
the
datadog_fix_panic
branch
from
da26354
to
228965f
Compare
|
/run-e2e datadog* |
|
Not sure if we should take the last point with a value (as proposed in this patch) or just return an error (or the filler value) if the last point has no value. |
|
To be consistent with the already existing behaviour, could you just return an error (or the fill value)? I mean, avoiding the panic but returning 0 or fill value like in other errors Tomorrow we will do a hotfix release, and I'd like to include this PR if you have time to change the code today |
Signed-off-by: Valentin Flaux <vflaux@oui.sncf>
vflaux
force-pushed
the
datadog_fix_panic
branch
from
228965f
to
6762b32
Compare
|
/run-e2e datadog* |
5 tasks
andyatwork
pushed a commit
to andyatwork/keda
that referenced
this pull request
Oct 31, 2022
Signed-off-by: Valentin Flaux <vflaux@oui.sncf> Signed-off-by: Valentin Flaux <vflaux@oui.sncf>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In getQueryResult(), check if the last point as a value before dereferencing it.
In the datadog scaler, returns the value of the last point with a value instead of the value of the last point.This fixes a panic when the last point has a nil value when we try to dereference it.
Also moves duplicated code used when no metric can be found to a dedicated function.Checklist
Fixe #3448