Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added panel regarding ammount of HPA #3934

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Added panel regarding ammount of HPA #3934

merged 1 commit into from
Dec 4, 2022

Conversation

yuvalweber
Copy link
Contributor

@yuvalweber yuvalweber commented Nov 29, 2022

added panel regarding HPA current/max replicas

Relates to #3911

@yuvalweber yuvalweber requested a review from a team as a code owner November 29, 2022 22:18
@yuvalweber yuvalweber changed the title Added panel regarding ammount of HPA, include #3911 Added panel regarding ammount of HPA Nov 29, 2022
@yuvalweber yuvalweber closed this Nov 29, 2022
@yuvalweber yuvalweber reopened this Nov 29, 2022
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you please also update the Dashboard to target metrics exposed in KEDA Operator, we have just recently changed this a little bit. KEDA Operator is the ultimate source of prom metrics (prom metrics from Metrics Server are deprecated and will be removed).

There are the same metrics exposed by Operator, but they are slightly renamed, see for details: #3919

@yuvalweber
Copy link
Contributor Author

Added 😄 @zroubalik

@tomkerkhove
Copy link
Member

Would you mind posting a screenshot please?

config/grafana/keda-dashboard.json Outdated Show resolved Hide resolved
config/grafana/keda-dashboard.json Outdated Show resolved Hide resolved
@yuvalweber
Copy link
Contributor Author

Would you mind posting a screenshot please?

Screen Shot 2022-11-30 at 10 18 52

@tomkerkhove
Copy link
Member

Do we want to see just over time or also current? We might want to add a gauge?
https://grafana.com/docs/grafana/v9.0/visualizations/#gauge

@yuvalweber
Copy link
Contributor Author

Do we want to see just over time or also current? We might want to add a gauge? https://grafana.com/docs/grafana/v9.0/visualizations/#gauge

Do you want to add a new one or to replace the current one with gauge?

@tomkerkhove
Copy link
Member

It's just an idea but I would add both

@yuvalweber
Copy link
Contributor Author

hey @zroubalik can you comment regarding this change?

@yuvalweber
Copy link
Contributor Author

Screen Shot 2022-12-02 at 9 12 00

also tried to added this as a gauge and I want your opinions about the look (I liked the time based better because I found the option using the graph to show the current vs max when it let you shows what the max value is). But please also comment on this and if you think it's helpful I'll upload it so we could deliver the grafana dashboard to users 😄 @tomkerkhove

@tomkerkhove
Copy link
Member

I think both are perfect - Left shows current status easily, right you can see it over time if you want more details.

What are your thoughts @zroubalik @JorTurFer ?

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@yuvalweber
Copy link
Contributor Author

So I'll add the second panel today to the PR and merge ok?
@tomkerkhove @zroubalik

@zroubalik
Copy link
Member

So I'll add the second panel today to the PR and merge ok? @tomkerkhove @zroubalik

yeah :)

@yuvalweber
Copy link
Contributor Author

I can't seem to be authorize to merge to this branch so whenever you can please merge 😄

Signed-off-by: Yuval Weber <yuval199985@gmail.com>
@tomkerkhove
Copy link
Member

I can't seem to be authorize to merge to this branch so whenever you can please merge 😄

That is by design :)

Thank you!

@tomkerkhove tomkerkhove merged commit af948a5 into kedacore:main Dec 4, 2022
@yuvalweber yuvalweber deleted the grafana-panel branch December 4, 2022 12:01
josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
@tomkerkhove
Copy link
Member

@yuvalweber Do you have an example screenshot of the full dashboard that we can add to our release blog post?

@yuvalweber
Copy link
Contributor Author

yeah of course I'll do it today @tomkerkhove

@tomkerkhove
Copy link
Member

@yuvalweber Did you manage to create one? If not, no problem.

@yuvalweber
Copy link
Contributor Author

Sorry for late response.
This is what I have @tomkerkhove
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants