-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added panel regarding ammount of HPA #3934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, could you please also update the Dashboard to target metrics exposed in KEDA Operator, we have just recently changed this a little bit. KEDA Operator is the ultimate source of prom metrics (prom metrics from Metrics Server are deprecated and will be removed).
There are the same metrics exposed by Operator, but they are slightly renamed, see for details: #3919
Added 😄 @zroubalik |
Would you mind posting a screenshot please? |
Do we want to see just over time or also current? We might want to add a gauge? |
Do you want to add a new one or to replace the current one with gauge? |
It's just an idea but I would add both |
hey @zroubalik can you comment regarding this change? |
also tried to added this as a gauge and I want your opinions about the look (I liked the time based better because I found the option using the graph to show the current vs max when it let you shows what the max value is). But please also comment on this and if you think it's helpful I'll upload it so we could deliver the grafana dashboard to users 😄 @tomkerkhove |
I think both are perfect - Left shows current status easily, right you can see it over time if you want more details. What are your thoughts @zroubalik @JorTurFer ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
So I'll add the second panel today to the PR and merge ok? |
yeah :) |
I can't seem to be authorize to merge to this branch so whenever you can please merge 😄 |
Signed-off-by: Yuval Weber <yuval199985@gmail.com>
That is by design :) Thank you! |
@yuvalweber Do you have an example screenshot of the full dashboard that we can add to our release blog post? |
yeah of course I'll do it today @tomkerkhove |
@yuvalweber Did you manage to create one? If not, no problem. |
Sorry for late response. |
added panel regarding HPA current/max replicas
Relates to #3911