fix: NewRelic scaler crashes on logging #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com>
JorTurFer
approved these changes
Dec 2, 2022
|
/run-e2e new_relic* |
tomkerkhove
reviewed
Dec 2, 2022
Comment on lines
78
to
+79
| - **Azure Blob Scaler** Store forgotten logger ([#3811](https://github.com/kedacore/keda/issues/3811)) | ||
| - **New Relic Scaler** Store forgotten logger ([#3945](https://github.com/kedacore/keda/issues/3945)) |
There was a problem hiding this comment.
@kedacore/keda-maintainers We had this twice; should we verify all our scalers?
There was a problem hiding this comment.
Could be a good idea, let me open an issue to track it
josephangbc
pushed a commit
to josephangbc/keda
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com>
josephangbc
pushed a commit
to josephangbc/keda
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com>
pedro-stanaka
pushed a commit
to pedro-stanaka/keda
that referenced
this pull request
Jan 18, 2023
Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com>
7 tasks
pedro-stanaka
pushed a commit
to pedro-stanaka/keda
that referenced
this pull request
Jan 18, 2023
Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
pedro-stanaka
pushed a commit
to pedro-stanaka/keda
that referenced
this pull request
Jan 19, 2023
Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
pedro-stanaka
pushed a commit
to pedro-stanaka/keda
that referenced
this pull request
Jan 19, 2023
Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
JorTurFer
added a commit
that referenced
this pull request
Jan 19, 2023
* fix: CVE-2022-3172 (#3693) Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * fix: Respect optional parameter inside envs for ScaledJobs (#3694) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * fix(prometheus scaler): Detect Inf before casting float to int (#3762) * fix(prometheus scaler): Detect Inf before casting float to int Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Improve the log message Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * fix(nats-jetstream): correctly count messages that should be redelivered (waiting for ack) towards keda value (#3809) * fix: keda now include the messages that should be retried in the count of pending messages used for scaling Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com> * chore: update changelog Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com> Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * NewRelic scaler crashes on logging (#3946) Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Fix stackdriver client returning 0 for metric types of double (#3788) * Update stackdriver client to handle metrics of value type double Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> * move change log note to below general Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> * parse activation value as float64 Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> * change target value to float64 for GCP pub/sub and stackdriver Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Fixing conflicts after cherry-pick Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * fix: Close is called twice on PushScaler's deletion (#3599) Signed-off-by: ytz <1020560484@qq.com> Signed-off-by: taenyang <1020560484@qq.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * fix/datadog-scaler-null-last-point (#3954) Signed-off-by: Tony Lee <dogzzdogzz@gmail.com> Signed-off-by: Tony Lee <tony.lee@shopback.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Tony Lee <tony.lee@shopback.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * fix(mongodb): escape username and password (#3989) Fixes #3992 Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Hacking generated files to version CI expects Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Updating aws-sdk and golang packages to fix CVEs Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Updating golang/text package to fix CVE Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * Using same version of aws sdk as in main Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Antoine Laffargue <antoine.laffargue@gmail.com> Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Eric Takemoto <24865872+octothorped@users.noreply.github.com> Signed-off-by: ytz <1020560484@qq.com> Signed-off-by: taenyang <1020560484@qq.com> Signed-off-by: Tony Lee <dogzzdogzz@gmail.com> Signed-off-by: Tony Lee <tony.lee@shopback.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Antoine LAFFARGUE <antoine.laffargue@gmail.com> Co-authored-by: Laszlo Kishalmi <laszlo.kishalmi@gmail.com> Co-authored-by: Eric Takemoto <eric.takemoto@gocrisp.com> Co-authored-by: taenyang <1020560484@qq.com> Co-authored-by: Tony Lee <dogzzdogzz@gmail.com> Co-authored-by: Tony Lee <tony.lee@shopback.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laszlo Kishalmi laszlo.kishalmi@partech.com
Trivial fix for #3945. The logging was initialized, but not saved return value. Took the idea from: #3811
Checklist
Fixes #3945