New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more logs to debug the output of Sarama `DescribeTopics` method #5141

Merged

zroubalik merged 4 commits into kedacore:main from dttung2905:feat-logging-topic-metadata-kafka-scaler

Nov 16, 2023

Contributor

dttung2905 commented Oct 30, 2023 •

edited

Loading

Provide a description of what has been changed

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Changelog has been updated and is aligned with our changelog requirements
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #5102

dttung2905 requested a review from a team as a code owner

October 30, 2023 22:39

github-actions bot commented Oct 30, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Our contribution guide

JorTurFer reviewed

View reviewed changes

pkg/scalers/kafka_scaler.go Outdated Show resolved Hide resolved

dttung2905 force-pushed the feat-logging-topic-metadata-kafka-scaler branch from e9cc8ee to cefece4 Compare

November 2, 2023 21:54

Contributor Author

dttung2905 commented Nov 3, 2023

=== RUN   TestPrometheusScalerExecutePromQueryParameters
    prometheus_scaler_test.go:402: Expect request path to = /api/v1/query?query=&time=2023-11-02T22:05:25Z&first=foo&second=bar but it is /api/v1/query?query=&time=2023-11-02T22:05:25Z&second=bar&first=foo
--- FAIL: TestPrometheusScalerExecutePromQueryParameters (0.00s)

https://github.com/kedacore/keda/actions/runs/6738632518/job/18318624696?pr=5141
let me check this later. Probably need a rebase

Member

zroubalik commented Nov 3, 2023 •

edited by github-actions bot

Loading

/run-e2e kafka
Update: You can check the progress here

dttung2905 force-pushed the feat-logging-topic-metadata-kafka-scaler branch from cefece4 to b2e1b83 Compare

November 5, 2023 10:04

Contributor Author

dttung2905 commented Nov 5, 2023

@zroubalik could you help to run the e2e test again? I rebased to main and all tests passed

Member

zroubalik commented Nov 6, 2023 •

edited by github-actions bot

Loading

/run-e2e
Update: You can check the progress here

Member

zroubalik commented Nov 9, 2023 •

edited by github-actions bot

Loading

/run-e2e kafka
Update: You can check the progress here

Contributor Author

dttung2905 commented Nov 9, 2023

@zroubalik the E2E test still fails. I'm not sure whether its because of the change I introduce or flaky test though. Is there a way to get some logs on this ? 🤔

Member

zroubalik commented Nov 13, 2023 •

edited by github-actions bot

Loading

/run-e2e kafka
Update: You can check the progress here

dttung2905 force-pushed the feat-logging-topic-metadata-kafka-scaler branch from b2e1b83 to 5d459a5 Compare

November 13, 2023 18:53

Member

zroubalik commented Nov 13, 2023 •

edited by github-actions bot

Loading

/run-e2e kafka
Update: You can check the progress here

dttung2905 closed this

dttung2905 reopened this

Member

zroubalik commented Nov 15, 2023 •

edited by github-actions bot

Loading

/run-e2e kafka
Update: You can check the progress here

dttung2905 added 4 commits

November 16, 2023 15:14


          Add more logs to debug the output of Sarama DescribeTopics

669d5c4

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>


          Add CHANGELOG.md

470ce9d

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>


          Fix CHANGELOG and put appropriate log level

20747ac

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>


          Make logging consistent in both kafka scalers

b729014

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

dttung2905 force-pushed the feat-logging-topic-metadata-kafka-scaler branch from 5d459a5 to b729014 Compare

November 16, 2023 15:15

Member

zroubalik commented Nov 16, 2023 •

edited by github-actions bot

Loading

/run-e2e kafka
Update: You can check the progress here

zroubalik approved these changes

View reviewed changes

Member

zroubalik left a comment

LGTM

zroubalik enabled auto-merge (squash)

November 16, 2023 15:35

zroubalik merged commit 5211cda into kedacore:main

19 checks passed

yoongon pushed a commit to yoongon/keda that referenced this pull request


          Add more logs to debug the output of Sarama DescribeTopics method (k…

581bea1

…edacore#5141)

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Yoon Park <yoongon.park@gmail.com>

toniiiik pushed a commit to toniiiik/keda that referenced this pull request


          Add more logs to debug the output of Sarama DescribeTopics method (k…

4a47c1a

…edacore#5141)

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: anton.lysina <alysina@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet