Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Pub/Sub resources from scale target's environment #5701

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Resolve Pub/Sub resources from scale target's environment #5701

merged 3 commits into from
Apr 19, 2024

Conversation

jtymes
Copy link
Contributor

@jtymes jtymes commented Apr 17, 2024 •
edited by JorTurFer
Loading

Provide a description of what has been changed

Checklist

  • [] When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5693

Relates to kedacore/keda-docs#1377

@jtymes
Allow for reading the topic/subscription names from the target enviro…
37bc605 
…nment

Signed-off-by: Jeremy Tymes <jeremy@jtymes.net>
@jtymes
Add env tests
7b4f5dc 
Signed-off-by: Jeremy Tymes <jeremy@jtymes.net>
@jtymes
Update CHANGELOG
1a845b6 
Signed-off-by: Jeremy Tymes <jeremy@jtymes.net>
@jtymes jtymes requested a review from a team as a code owner April 17, 2024 10:32
@JorTurFer
Copy link
Member

JorTurFer commented Apr 18, 2024 •
edited by github-actions bot
Loading

/run-e2e gcp
Update: You can check the progress here

@JorTurFer
Copy link
Member

nice improvement!!!

@zroubalik zroubalik merged commit 31d848c into kedacore:main Apr 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve GCP Pub/Sub subscription or topic name from the target's environment
3 participants
@jtymes @JorTurFer @zroubalik