Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address naming changes for postgresql scaler #593

Merged
merged 1 commit into from
Feb 3, 2020
Merged

address naming changes for postgresql scaler #593

merged 1 commit into from
Feb 3, 2020

Conversation

dimberman
Copy link
Contributor

No description provided.

@dimberman
Copy link
Contributor Author

@tomkerkhove can we figure out what other variable name changes we should do?

tomkerkhove
tomkerkhove approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, connection or connectionString are fine for me.

tomkerkhove
tomkerkhove approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, connection or connectionString are fine for me.

zroubalik
zroubalik requested changes Feb 3, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should even rename the postgres_scaler.go file

pkg/scalers/postgres_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/postgres_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/postgres_scaler.go Show resolved Hide resolved
pkg/scalers/postgres_scaler.go Outdated Show resolved Hide resolved
@dimberman dimberman force-pushed the fix-postgres-variable-names branch 3 times, most recently from 2b79546 to 123a181 Compare February 3, 2020 15:44
zroubalik
zroubalik requested changes Feb 3, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some outstanding minor places to update. Thanks!

pkg/scalers/postgresql_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/postgresql_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/postgresql_scaler.go Show resolved Hide resolved
pkg/scalers/postgresql_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/postgresql_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/postgresql_scaler.go Outdated Show resolved Hide resolved
zroubalik
zroubalik approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ahmelsayed
Copy link
Contributor

Thanks @dimberman and @zroubalik :)

@ahmelsayed ahmelsayed merged commit b068c64 into kedacore:master Feb 3, 2020
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
@chalin
No longer list scaler subentries in top- or side- navs (kedacore#593)
24a6936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@Aarthisk Aarthisk Awaiting requested review from Aarthisk

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimberman @ahmelsayed @zroubalik @tomkerkhove @astro-sql-decorator