Add redis host and port parameter to the scaler with tests #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Gualandri <ivan.gualandri@gmail.com>
|
@zroubalik i messed up with the previous PR, so this is the new one the code should be the same. |
SpiritZhou
pushed a commit
to SpiritZhou/keda
that referenced
this pull request
Jul 18, 2023
…edacore#719) Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should implement #694
(same code as PR #710 )
How does it works:
now the redis scaler accept 2 new parameters: host and port in addition of the already existing.
If address is specified it use the address, otherwise it checks the host and port parameters, they must be difned both, otherwise an error will be returned.
If address and host and port are all specified, address will get priority.
Checklist
Fixes #