Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ: make queueLength optional #881

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

RabbitMQ Scaler documentation mentiones that queueLength should be optional with default value 20, but the actual code doesn't reflect this.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • Tests have been added

Fixes #880

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@ahmelsayed ahmelsayed merged commit 6f71dcd into kedacore:master Jun 16, 2020
tbickford pushed a commit to tbickford/keda that referenced this pull request Jun 21, 2020
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik deleted the rabbitmq branch August 11, 2020 11:34
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Signed-off-by: Deepak <sah.sslpu@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The attribute "queueLength" of RabbitMQ Scaler is not optional actually
3 participants