Add bitwise_for_parity_check #83
Open
+86
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manlikeHB
force-pushed
the
bitwise_for_parity_check
branch
from
4069c2a
to
fd0e93b
Compare
manlikeHB
force-pushed
the
bitwise_for_parity_check
branch
from
2892a93
to
e76d7fd
Compare
manlikeHB
changed the title
0xLucqs
requested changes
Sep 20, 2024
|
|
||
| //! > cairo_code | ||
| fn main() { | ||
| let a = 200 & 1; |
There was a problem hiding this comment.
Suggested change
| let a = 200 & 1; | |
| let a = 200_u32 & 1; |
| pub fn fix_bitwise_for_parity_check(&self, db: &dyn SyntaxGroup, node: ExprBinary) -> String { | ||
| let lhs = node.lhs(db).as_syntax_node().get_text(db); | ||
|
|
||
| format!("DivRem::div_rem({}, 2)", lhs.trim()) |
There was a problem hiding this comment.
Suggested change
| format!("DivRem::div_rem({}, 2)", lhs.trim()) | |
| format!("{} % 2", lhs.trim()) |
| pub const BITWISE_FOR_PARITY: &str = | ||
| "You seem to be trying to use `&` for parity check. Consider using `DivRem::div_rem()` instead."; | ||
|
|
||
| pub fn check_bitwise_for_parity(db: &dyn SyntaxGroup, node: &ExprBinary, diagnostics: &mut Vec<PluginDiagnostic>) { |
There was a problem hiding this comment.
You should check that this type indeed implements DivRem so i don't think you should be using SyntaxGroup but use SemanticGroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65