Update tsd #359
Merged
Update tsd #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned #340 (comment), I'm not sure if these changes are correct since I'm not familiar with typescript. |
mAAdhaTTah
reviewed
Nov 20, 2021
| expectType<Event<string, number>>(logItem({type: 'value', value: 'hello'}, false)) | ||
| expectType<Event<string, string>>(logItem({type: 'value', value: 'hello'}, false)) |
There was a problem hiding this comment.
Does this fail? I think this is intended to communicate that the Error type can be anything. Which maybe implies it should be unknown?
There was a problem hiding this comment.
Yes, it fails. You can see the failures on the PR created by dependabot.
I could change it to unknown if that's the correct fix, I really don't know. It seems odd that tests were passing before.
mAAdhaTTah
approved these changes
Nov 20, 2021
|
Needs a rebase. |
|
@mAAdhaTTah I've rebased and updated tsd to latest (0.19), it was previous on 0.18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.