Set bin height to 1mm #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivated by [kennetek#147](kennetek#147), I think it ends up more intuitive if upon opening the bin is actually a bin. From a first impression perspective, it seems unlikely a user is opening up the bins.scad to produce a bin-sized-blank vs. a bin.
Ruudjhuu
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Could you improve the "default values" part so when divx and divy are used, height_internal is set to 0?
would also be nice to add a message to the user when one of divx and divy is >0 and the other one is 0. They both need to be >0 or both exaclty 0.
I would like to see the first thing happen before merging this request, the second part is a nice to have, no must for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #147, I think it ends up more intuitive if upon opening the bin is actually a bin.
From a first impression perspective, it seems unlikely a user is opening up the bins.scad to produce a bin-sized-blank vs. a bin.