Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chamfers to cylindrical cutout holes #161

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

tstranex
Copy link
Contributor

@tstranex tstranex commented Feb 3, 2024

Here's how it looks in preview mode:

preview

Here's how it looks in render mode:

render

@w33ble
Copy link

w33ble commented Feb 8, 2024

FYI, it would help to add this to the arguments passed to cutCylinders so that it works out of the box. Without that, changing that parameter doesn't do anything.

This is a nice addition though 👍🏾

diff --git a/gridfinity-rebuilt-bins.scad b/gridfinity-rebuilt-bins.scad
index ff1d930..ea176a9 100644
--- a/gridfinity-rebuilt-bins.scad
+++ b/gridfinity-rebuilt-bins.scad
@@ -95,7 +95,7 @@ gridfinityInit(gridx, gridy, height(gridz, gridz_define, style_lip, enable_zsnap

     } else if (cdivx > 0 && cdivy > 0) {

-        cutCylinders(n_divx=cdivx, n_divy=cdivy, cylinder_diameter=cd, cylinder_height=ch, coutout_depth=c_depth, orientation=c_orientation);
+        cutCylinders(n_divx=cdivx, n_divy=cdivy, cylinder_diameter=cd, cylinder_height=ch, coutout_depth=c_depth, orientation=c_orientation, chamfer=c_chamfer);
     }
 }
 gridfinityBase(gridx, gridy, l_grid, div_base_x, div_base_y, style_hole, only_corners=only_corners);
image

@tstranex
Copy link
Contributor Author

tstranex commented Feb 9, 2024

@w33ble Ah, good catch, thanks! I've updated the code in the pull request.

w33ble added a commit to w33ble/gridfinity-rebuilt-openscad that referenced this pull request Feb 9, 2024
w33ble added a commit to w33ble/gridfinity-rebuilt-openscad that referenced this pull request Feb 9, 2024
@Ruudjhuu Ruudjhuu merged commit 74d40ad into kennetek:main Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants