RFC: Attempt to fix radius defines #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same value used in baseplate is now handled as radius (instead of diameter).
Also introduce d_fo1 = 2 * r_fo1 in places where diameter seems to be used.
Ruudjhuu
approved these changes
Feb 16, 2024
|
Should have taken this opportunity to fix the incorrect comments (these are diameters, not radii) |
@gshpychka Code was updated to use these values as radii. |
Oh, my bad, didn't realize that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first set of code smells I found due to #165. Pull request is split into 3 commits, one for each variable.