Update Stacking Lip Profile #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profile is now based on https://gridfinity.xyz/specification/ This does not change the final profile, merely how it is created. Fixes kennetek#168 - Cura watertight issue. Paritally fixes kennetek#169 - FreeCad errors.
|
Much larger than the last one, but hopefully I've commented enough to show how everything works. Feel free to ask questions. Shape was verified in multiple ways:
If you like this approach, I may take a shot at re-creating the bases in a similar manner. The sweep function is really neat, and can avoid the need to deal with the annoyances |
EmperorArthur
force-pushed
the
fix_wall_profile
branch
2 times, most recently
from
b0b483a
to
015daff
Compare
EmperorArthur
force-pushed
the
fix_wall_profile
branch
from
71281fa
to
5b25e2e
Compare
Ruudjhuu
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profile is now based on https://gridfinity.xyz/specification/
This does not change the final profile, merely how it is created.Fixes #168 - Cura watertight issue.
Fixes #169 - FreeCad errors.
Edit: Also Fixes #165