[WIP] Feature/poc GitHub actions #69
Conversation
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
…/job-executor-service into feature/poc-github-actions
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "strings" | ||
| ) | ||
|
|
||
| func PrepareArgs(with map[string]string, inputs map[string]model.Input, args []string) ([]string, error) { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function PrepareArgs should have comment or be unexported
| "net/http" | ||
| ) | ||
|
|
||
| func GetActionYaml(githubRepoName string) (error, *model.Action) { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
error should be the last type when returning multiple items
| "net/http" | ||
| ) | ||
|
|
||
| func GetActionYaml(githubRepoName string) (error, *model.Action) { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function GetActionYaml should have comment or be unexported
| return nil, action | ||
| } | ||
|
|
||
| func readActionYamlFromGithub(githubRepoName string) (error, []byte) { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
error should be the last type when returning multiple items
pkg/github/model/workflow.go
Outdated
| RawMatrix yaml.Node `yaml:"matrix"` | ||
| } | ||
|
|
||
| // Default settings that will apply to all steps in the job or workflow |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
comment on exported type Defaults should be of the form "Defaults ..." (with optional leading article)
pkg/github/model/workflow.go
Outdated
| Run RunDefaults `yaml:"run"` | ||
| } | ||
|
|
||
| // Defaults for all run steps in the job or workflow |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
comment on exported type RunDefaults should be of the form "RunDefaults ..." (with optional leading article)
| @@ -0,0 +1,39 @@ | |||
| package github | |||
There was a problem hiding this comment.
[gofmt] reported by reviewdog 🐶
file pkg/github/github.go is not gofmted
| @@ -0,0 +1,43 @@ | |||
| package github | |||
There was a problem hiding this comment.
[gofmt] reported by reviewdog 🐶
file pkg/github/github_test.go is not gofmted
| @@ -0,0 +1,63 @@ | |||
| package model | |||
There was a problem hiding this comment.
[gofmt] reported by reviewdog 🐶
file pkg/github/model/action.go is not gofmted
| @@ -0,0 +1,78 @@ | |||
| package model | |||
There was a problem hiding this comment.
[gofmt] reported by reviewdog 🐶
file pkg/github/model/workflow.go is not gofmted
| @@ -0,0 +1,16 @@ | |||
| package k8sutils | |||
There was a problem hiding this comment.
[gofmt] reported by reviewdog 🐶
file pkg/k8sutils/builder_test.go is not gofmted
pkg/eventhandler/eventhandlers.go
Outdated
|
|
||
| _, err := eh.Keptn.SendTaskStartedEvent(eh.EventData, eh.ServiceName) | ||
| if err != nil { | ||
| return fmt.Errorf("Error while sending started event: %s\n", err.Error()) |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
error strings should not be capitalized or end with punctuation or a newline
pkg/eventhandler/eventhandlers.go
Outdated
|
|
||
| err = k8s.ConnectToCluster() | ||
| if err != nil { | ||
| return fmt.Errorf("Error while connecting to cluster: %s\n", err.Error()) |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
error strings should not be capitalized or end with punctuation or a newline
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
| @@ -0,0 +1,100 @@ | |||
| package k8sutils | |||
There was a problem hiding this comment.
[gofmt] reported by reviewdog 🐶
file pkg/k8sutils/builder.go is not gofmted
|
The following Docker Images have been built:
|
No description provided.