-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add Example] Create reproducibility_recipes.py #1353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a useful guide - I think we could greatly simplify this code and make it very concise by removing a lot of the module inspection code and some of the more complex logic loops!
@LukeWood Thanks for the review, I simplified those parts, can you take a look at when you have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Looking good! 👍
Hi @fchollet, thank you for your comments. Now I provided more explanation for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Everything looks good to me. You can add the generated files.
@fchollet Done! I think this is ready to be merged 😄 Here's a snippet: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the great contribution! 👍
This quick Keras recipe demonstrates how Keras initializers behave, and shows what's needed to achieve identical results in subsequential runs in model training process.
#1332