This repository has been archived by the owner on Mar 7, 2019. It is now read-only.
Fix #194 once again #294
Merged
Fix #194 once again #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No shame in it. I'm pretty sure this repo has had many things borrowed from it. 👍 I'll test it out as early as today thanks! |
|
Confirmed this fixes #194 for me in 7.3 w/Archetype 1.10. Thanks Kenn! |
|
@tomfulton can you merge or do you not have access? |
|
We need to mark the next release to depend on 7.3.0+ |
|
Hey guys. I believe this is backwards compatible... at least it works on my machine in 7.2.8 :) No matter what, I think it would be silly to make the next release depend on 7.3+ just for handling RTE dragging. If this fix doesn't work on 7.2.x, I'd much rather implement a workaround for older versions of Umbraco than have a version dependency because of this issue. |
|
I can confirm it works in 7.2.8 and 7.3.0 so we can leave the dependency as-is 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright... I've shamelessly stolen and adapted the current Grid implementation and it works like a charm.
Note that I've removed the clean-up in
$scope.sortableOptions.stopas there doesn't seem to be a leak of editors anymore. You can verify this by addingconsole.log($(rteClass).length)in$scope.sortableOptions.stop.