Skip to content

Commit

Permalink
Fix flaky migrations actions test by using an index with more docs (e…
Browse files Browse the repository at this point in the history
…lastic#168848)

## Summary

Second attempt at:
fixes elastic#166190 
fixes elastic#166199


More data, more timeout 👯 I have not been able to cause this to fail
locally, but we don't have a flaky test running for jest integrations
tests to confirm. So the only way to fully test is to merge.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
rudolf and kibanamachine authored Oct 23, 2023
1 parent 0a44a58 commit 3610091
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

import { createTestServers } from '@kbn/core-test-helpers-kbn-server';
import { MIGRATION_CLIENT_OPTIONS } from '@kbn/core-saved-objects-migration-server-internal';
import { runActionTestSuite } from './actions_test_suite';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ export const runActionTestSuite = ({
{ _source: { title: 'doc 3' } },
{ _source: { title: 'saved object 4', type: 'another_unused_type' } },
{ _source: { title: 'f-agent-event 5', type: 'f_agent_event' } },
{ _source: { title: new Array(1000).fill('a').join(), type: 'large' } }, // "large" saved object
{
_source: { title: new Array(1000).fill('a').join(), type: 'large' },
}, // "large" saved objects
] as unknown as SavedObjectsRawDoc[];
await bulkOverwriteTransformedDocuments({
client,
Expand All @@ -113,6 +115,27 @@ export const runActionTestSuite = ({
refresh: 'wait_for',
})();

await createIndex({
client,
indexName: 'existing_index_with_100k_docs',
aliases: ['existing_index_with_100k_docs_alias'],
esCapabilities,
mappings: {
dynamic: true,
properties: {},
},
})();
const docs100k = new Array(100000).fill({
_source: { title: new Array(1000).fill('a').join(), type: 'large' },
}) as unknown as SavedObjectsRawDoc[]; // 100k "large" saved objects

await bulkOverwriteTransformedDocuments({
client,
index: 'existing_index_with_100k_docs',
operations: docs100k.map((doc) => createBulkIndexOperationTuple(doc)),
refresh: 'wait_for',
})();

await createIndex({
client,
indexName: 'existing_index_2',
Expand Down Expand Up @@ -756,8 +779,7 @@ export const runActionTestSuite = ({

// Reindex doesn't return any errors on it's own, so we have to test
// together with waitForReindexTask
// Failing: See https://github.com/elastic/kibana/issues/166190
describe.skip('reindex & waitForReindexTask', () => {
describe('reindex & waitForReindexTask', () => {
it('resolves right when reindex succeeds without reindex script', async () => {
const res = (await reindex({
client,
Expand Down Expand Up @@ -1122,15 +1144,16 @@ export const runActionTestSuite = ({
it('resolves left wait_for_task_completion_timeout when the task does not finish within the timeout', async () => {
const readyTaskRes = await waitForIndexStatus({
client,
index: 'existing_index_with_docs',
index: 'existing_index_with_100k_docs',
status: 'yellow',
timeout: '300s',
})();

expect(Either.isRight(readyTaskRes)).toBe(true);

const res = (await reindex({
client,
sourceIndex: 'existing_index_with_docs',
sourceIndex: 'existing_index_with_100k_docs',
targetIndex: 'reindex_target',
reindexScript: Option.none,
requireAlias: false,
Expand Down Expand Up @@ -1428,8 +1451,7 @@ export const runActionTestSuite = ({
});
});

// Failing: See https://github.com/elastic/kibana/issues/166199
describe.skip('waitForPickupUpdatedMappingsTask', () => {
describe('waitForPickupUpdatedMappingsTask', () => {
it('rejects if there are failures', async () => {
const res = (await pickupUpdatedMappings(
client,
Expand Down Expand Up @@ -1469,7 +1491,7 @@ export const runActionTestSuite = ({
it('resolves left wait_for_task_completion_timeout when the task does not complete within the timeout', async () => {
const res = (await pickupUpdatedMappings(
client,
'existing_index_with_docs',
'existing_index_with_100k_docs',
1000
)()) as Either.Right<UpdateByQueryResponse>;

Expand Down

0 comments on commit 3610091

Please sign in to comment.