Skip to content

Commit

Permalink
fix: make platformId optional in node object (#105)
Browse files Browse the repository at this point in the history
  • Loading branch information
shubhbapna committed Jun 9, 2023
1 parent 1ca9dcd commit dcd068d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@kie/build-chain-configuration-reader",
"version": "3.1.2",
"version": "3.1.3",
"description": "A library to read build-chain tool configuration files",
"main": "build/src/index.js",
"types": "build/src/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion src/domain/node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ export interface Node {
mapping?: Mapping;
clone?: string[];
archiveArtifacts?: ArchiveArtifacts;
platformId: string
platformId?: string
}
3 changes: 1 addition & 2 deletions src/util/construct-node.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { Build, BuildCommand, CommandLevel } from "@bc-cr/domain/build";
import { Dependency } from "@bc-cr/domain/dependencies";
import { Node } from "@bc-cr/domain/node";
import { DEFAULT_GITHUB_PLATFORM } from "@bc-cr/domain/platform";

export function constructNode(
dependency: Dependency,
Expand All @@ -27,7 +26,7 @@ export function constructNode(
current: buildCommand?.current ?? [],
},
...(clone ? { clone } : {}),
platformId: dependency.platform ?? DEFAULT_GITHUB_PLATFORM.id
platformId: dependency.platform
};
}

Expand Down

0 comments on commit dcd068d

Please sign in to comment.