Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo upgrade --manifest-path only works with absolute paths #565

Closed
epage opened this issue Jan 18, 2022 · 0 comments · Fixed by #732
Closed

cargo upgrade --manifest-path only works with absolute paths #565

epage opened this issue Jan 18, 2022 · 0 comments · Fixed by #732

Comments

@epage
Copy link
Collaborator

epage commented Jan 18, 2022

We try to find the path in the CargoMetadata but it won't match.

cargo-set-version should have the needed logic for this. I guess an alternative to dunce::canonicalize is same_file.

When fixing this, we should copy tests/cmd/upgrade/workspace_member_cwd.* into a _manifest_path test that specifies the manifest path instead of relying on cwd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant