This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Keep Old Student Submissions (Using Pandas) #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkagin
force-pushed
the
keep_old_student_submissions_v2
branch
from
3b6d255
to
4342097
Compare
|
@dchess This does work for me, but it is taking a lot of memory and about ~2 extra minutes to run. I defer to you on which approach you would prefer. |
zkagin
force-pushed
the
keep_old_student_submissions_v2
branch
from
4342097
to
ab77f96
Compare
|
@dchess Never mind, mine actually silently ends with what I assume is a memory error once I pulled the whole list. I unfortunately don't think this is a viable method. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91
Instead of dropping and rewriting the student submissions database, this endpoint now appends new files and then removes duplicates based on the updateTime. This PR also adds some new testing functionality to allow for alternate return values so that it can properly test getting a value that needs to be updated.
Similar to #99, but uses pandas to deduplicate instead of SQL to do the deduplication. This might cause memory issues. @dchess Can you try running this to see if it works for you?