Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New names for the Noto CJK fonts #11

Closed
3 tasks done
xfq opened this issue Sep 1, 2023 · 1 comment
Closed
3 tasks done

New names for the Noto CJK fonts #11

xfq opened this issue Sep 1, 2023 · 1 comment
Labels
enhancement New feature or request font-selection 用于跟踪有关字体选择的问题,包括字体排列方案、字形、符号和跨平台支持等

Comments

@xfq
Copy link
Contributor

xfq commented Sep 1, 2023

Clear and concise description of the problem

According to https://bugs.documentfoundation.org/show_bug.cgi?id=137393 , it looks like Google changed the name of the Noto CJK fonts. So we probably want to add the new names to the font stack.

Suggested solution

  1. In addition to Noto Serif CJK SC, add Noto Serif SC.
  2. In addition to Noto Sans CJK SC, add Noto Sans SC.

Alternative

No response

Additional context

No response

Validations

@xfq xfq added the enhancement New feature or request label Sep 1, 2023
@kirklin kirklin added the font-selection 用于跟踪有关字体选择的问题,包括字体排列方案、字形、符号和跨平台支持等 label Sep 1, 2023
@kirklin
Copy link
Owner

kirklin commented Sep 5, 2023

Thanks for addressing the issue related to the Noto CJK fonts' name change. Your proposed solution looks good.

Adding "Noto Serif SC" and "Noto Sans SC" in addition to their previous versions ("Noto Serif CJK SC" and "Noto Sans CJK SC") makes sense, as it ensures compatibility with the new names while maintaining compatibility with the old ones.

Resolving this in version v0.2.1.

Great job!

@kirklin kirklin closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request font-selection 用于跟踪有关字体选择的问题,包括字体排列方案、字形、符号和跨平台支持等
Projects
None yet
Development

No branches or pull requests

2 participants