Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceIdentifierType is allowed to be 'null' #198

Closed
VolkerHartmann opened this issue Jan 30, 2023 · 2 comments
Closed

ResourceIdentifierType is allowed to be 'null' #198

VolkerHartmann opened this issue Jan 30, 2023 · 2 comments
Assignees
@VolkerHartmann
Labels
bug Something isn't working

Comments

@VolkerHartmann
Copy link
Contributor

Describe the bug
Creating a metadata document with a related resource without providing its type results in a NPE.

To Reproduce
Steps to reproduce the behavior:

  1. Ingest a schema with a schema record provide no type for given pid.
  2. See error (NPE instead of BadArgumentException)

Expected behavior
The HTTP status should be 400 (Bad argument)
@VolkerHartmann VolkerHartmann added the bug Something isn't working label Jan 30, 2023
@VolkerHartmann VolkerHartmann self-assigned this Jan 30, 2023
@github-actions
Copy link
Contributor

Branch issue-198-ResourceIdentifierType_is_allowed_to_be_null created!

github-actions bot pushed a commit that referenced this issue Jan 30, 2023
@VolkerHartmann
Create PR for #198
11af712
@github-actions github-actions bot mentioned this issue Jan 30, 2023
Merged
@VolkerHartmann
Copy link
Contributor Author

Fixed by 09b75d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VolkerHartmann VolkerHartmann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VolkerHartmann