Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to spring boot3 #319

Merged

Conversation

VolkerHartmann
Copy link
Contributor

@VolkerHartmann VolkerHartmann commented May 26, 2023

  • Bump SpringBoot to Version 3
  • Update dependencies
  • compile Code
  • Test code
    • Fix SecurityFilter
  • Update README.md
  • Update CHANGELOG.md

if (!enableCsrf) {
logger.info("CSRF disabled!");
httpSecurity = httpSecurity.csrf().disable();
httpSecurity = httpSecurity.csrf(csrf -> csrf.disable());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6% of developers fix this issue

SPRING_CSRF_PROTECTION_DISABLED: Disabling Spring Security's CSRF protection is unsafe for standard web applications


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@@ -75,7 +75,7 @@ public class MetadataRecord implements EtagSupport, Serializable {
private Long recordVersion;

@NotNull(message = "A list of access control entries for resticting access.")
@OneToMany(cascade = javax.persistence.CascadeType.ALL, orphanRemoval = true)
@OneToMany(cascade = jakarta.persistence.CascadeType.ALL, orphanRemoval = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4% of developers fix this issue

UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.


Suggested change
@OneToMany(cascade = jakarta.persistence.CascadeType.ALL, orphanRemoval = true)
@OneToMany(cascade = CascadeType.ALL, orphanRemoval = true)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Jun 28, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/kit-data-manager/metastore2/319.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/kit-data-manager/metastore2/319.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #319 (34588e9) into development (879f8cd) will decrease coverage by 1.61%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##             development     #319      +/-   ##
=================================================
- Coverage          88.07%   86.47%   -1.61%     
+ Complexity           921      914       -7     
=================================================
  Files                 73       73              
  Lines               3229     3245      +16     
  Branches             394      396       +2     
=================================================
- Hits                2844     2806      -38     
- Misses               254      309      +55     
+ Partials             131      130       -1     
Impacted Files Coverage Δ
...u/kit/datamanager/metastore2/domain/AclRecord.java 93.33% <ø> (ø)
.../kit/datamanager/metastore2/domain/DataRecord.java 88.88% <ø> (ø)
...anager/metastore2/domain/LinkedMetadataRecord.java 90.00% <ø> (ø)
.../datamanager/metastore2/domain/MetadataRecord.java 86.66% <ø> (ø)
...anager/metastore2/domain/MetadataSchemaRecord.java 97.05% <ø> (ø)
...amanager/metastore2/domain/ResourceIdentifier.java 100.00% <ø> (ø)
...it/datamanager/metastore2/domain/SchemaRecord.java 85.71% <ø> (ø)
...du/kit/datamanager/metastore2/domain/Url2Path.java 80.00% <ø> (ø)
...nager/metastore2/domain/oaipmh/MetadataFormat.java 75.00% <ø> (ø)
...manager/metastore2/filter/AccessLoggingFilter.java 90.00% <ø> (ø)
... and 33 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VolkerHartmann VolkerHartmann merged commit 05d10ac into kit-data-manager:development Jun 28, 2023
11 of 12 checks passed
@VolkerHartmann VolkerHartmann deleted the bumpToSpringBoot3 branch December 8, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant