Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata schemas with capital letters will not be indexed. #352

Conversation

github-actions[bot]
Copy link
Contributor

Original issue description

Describe the bug
If a metadata document is created that references a metadata schema whose name contains an uppercase letter, the metadata document will not be indexed.

To Reproduce
Steps to reproduce the behavior:

  1. Register a schema with a uppercase letter (e.g. myTest)
  2. Create a metadata document using this schema.
  3. Search for document.
  4. Metadata document is not part of the result.

Expected behavior
All matching documents should be listed.
Reason:
Since the index for elasticsearch is formed from the prefix 'metastore_' and the schema identifier, no capital letters are allowed for the identifier.

closes #351

@github-actions github-actions bot added the bug Something isn't working label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #352 (7fc5993) into development (9497fc4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##             development     #352      +/-   ##
=================================================
+ Coverage          87.75%   87.77%   +0.01%     
- Complexity           916      918       +2     
=================================================
  Files                 73       73              
  Lines               3234     3238       +4     
  Branches             391      391              
=================================================
+ Hits                2838     2842       +4     
  Misses               266      266              
  Partials             130      130              
Impacted Files Coverage Δ
...ager/metastore2/util/MetadataSchemaRecordUtil.java 78.90% <ø> (ø)
...anager/metastore2/domain/MetadataSchemaRecord.java 97.36% <100.00%> (+0.30%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VolkerHartmann VolkerHartmann merged commit 0b415fc into development Jul 14, 2023
12 checks passed
@VolkerHartmann VolkerHartmann deleted the issue-351-Metadata_schemas_with_capital_letters_will_not_be_indexed branch December 6, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant