merge parent route meta with children route meta #242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
createRoute
utility to use a newcombineMeta
to merge child meta with parent (if parent exists). This follows the pattern used for state (and others). Merging meta is just a bit unique in that duplicate keys are allowed as long as the child's property of the same name matchestypeof
for the parent. The thinking here being that the child can override the meta property of a parent.This PR also adds a new test suite for
createRoute
, with tests for new meta functionality as well as combine logic for other parts of the route.