Prefetch async route components #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kitbag-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stackoverfloweth
approved these changes
Sep 3, 2024
Comment on lines
+249
to
+252
| return new Promise(resolve => { | ||
| loaded = true | ||
| resolve({ default: { template: '' } }) | ||
| }) |
| const props = withDefaults(defineProps<RouterLinkProps & RouterPushOptions>(), { | ||
| // because prefetch can be a boolean vue automatically sets the default to false. | ||
| // Specifically setting the default to undefined | ||
| prefetch: undefined, |
There was a problem hiding this comment.
In general I really like how vue defaults booleans to false. But it can cause some surprising errors when you're not really expecting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new feature where if a route is defined with an async component (by using vue's
defineAsyncComponentutility) that component will be prefetched into the app when arouter-linkto that route is mounted.