Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic UI functionality #365

Merged
merged 39 commits into from
Oct 21, 2023
Merged

Basic UI functionality #365

merged 39 commits into from
Oct 21, 2023

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Oct 7, 2023

  • Display single post
  • Display profile
  • Home timeline
  • Local timeline
  • Global timeline

Note: When this is finished, we will retire our old templating-based solution for displaying profiles and posts in favour of this

Flake lock file updates:

• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/f5892ddac112a1e9b3612c39af1b72987ee5783a' (2023-09-29)
  → 'github:nixos/nixpkgs/81e8f48ebdecf07aab321182011b067aafc78896' (2023-10-03)
• Updated input 'rust-overlay':
    'github:oxalica/rust-overlay/611ccdceed92b4d94ae75328148d84ee4a5b462d' (2023-10-03)
  → 'github:oxalica/rust-overlay/126829788e99c188be4eeb805f144d73d8a00f2c' (2023-10-07)
@aumetra
Copy link
Member Author

aumetra commented Oct 8, 2023

Okay, this PR now has:

  • A basic home timeline
  • Basics of a post modal with WYSIWYG editing via TipTap
  • A basic post view (still missing threading)
  • Basic i18n in some places
  • Virtually scrolling timelines
  • Infinite scrolling (not yet actually fetching the new posts)

We are still missing:

  • The "post" button needs to actually post
  • Thread fetching for the post view
  • More extensive i18n
  • Fetching the posts for infinite scrolling
  • Profile view
  • Timelines
    • Local
    • Global

@aumetra aumetra force-pushed the aumetra/basic-ui-functionality branch from 41c599d to 6f63e5d Compare October 8, 2023 16:13
@aumetra
Copy link
Member Author

aumetra commented Oct 8, 2023

We should also define some breakpoints as variables and use them with SCSS mixins instead of having our weird hardcoded values.

Probably best to use some widely used values such as the ones of Tailwind or Bootstrap

@aumetra aumetra force-pushed the aumetra/basic-ui-functionality branch from 17fc959 to 221b3c2 Compare October 12, 2023 20:02
Flake lock file updates:

• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/81e8f48ebdecf07aab321182011b067aafc78896' (2023-10-03)
  → 'github:nixos/nixpkgs/f99e5f03cc0aa231ab5950a15ed02afec45ed51a' (2023-10-09)
• Updated input 'rust-overlay':
    'github:oxalica/rust-overlay/126829788e99c188be4eeb805f144d73d8a00f2c' (2023-10-07)
  → 'github:oxalica/rust-overlay/aa7584f5bbf5947716ad8ec14eccc0334f0d28f0' (2023-10-12)
@aumetra aumetra force-pushed the aumetra/basic-ui-functionality branch from 7da9755 to 6e807ca Compare October 12, 2023 21:11
@aumetra aumetra force-pushed the aumetra/basic-ui-functionality branch from 487e279 to 6f36a3a Compare October 14, 2023 14:42
@aumetra aumetra force-pushed the aumetra/basic-ui-functionality branch from 3d87dfb to 26a0c34 Compare October 15, 2023 10:58
Flake lock file updates:

• Updated input 'rust-overlay':
    'github:oxalica/rust-overlay/dce60ca7fca201014868c08a612edb73a998310f' (2023-10-14)
  → 'github:oxalica/rust-overlay/e494404d36a41247987eeb1bfc2f1ca903e97764' (2023-10-15)
@aumetra
Copy link
Member Author

aumetra commented Oct 15, 2023

The infinite scrolling is a little busted but I'm not sure why!

@aumetra aumetra mentioned this pull request Oct 21, 2023
13 tasks
@aumetra
Copy link
Member Author

aumetra commented Oct 21, 2023

Merging this here. This is getting too large. Gonna split up the missing parts into smaller PRs

@aumetra aumetra marked this pull request as ready for review October 21, 2023 14:51
@aumetra aumetra added this pull request to the merge queue Oct 21, 2023
Merged via the queue into main with commit cc1aa20 Oct 21, 2023
7 checks passed
@aumetra aumetra deleted the aumetra/basic-ui-functionality branch October 21, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants