Rework error representation #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also get a revamp of parts of the OAuth2 code which is a bit horribly organized. |
|
|
|
Removed |
aumetra
force-pushed
the
aumetra/error-repr
branch
from
a0a9ee9
to
f1bcd13
Compare
aumetra
force-pushed
the
aumetra/error-repr
branch
from
2b24e78
to
5270c7a
Compare
aumetra
force-pushed
the
aumetra/error-repr
branch
from
5c04ab3
to
0691c5a
Compare
|
(well, damn. Of course coverage increases if we delete ~1k LoC) |
aumetra
force-pushed
the
aumetra/error-repr
branch
from
b7442e5
to
ed555ea
Compare
aumetra
added a commit
that referenced
this pull request
Apr 7, 2024
* start error repr rework * add kitsune-error crate * progress * rm unused dependencies * progress * progress * progress * progress * finish * fix checks * fix tests * enable serde for garde * Add codecov token * remove some more error enums * remove another enum * remove httperror * improve somewhat * make it possible to return responses as the 'body' * use try-block polyfills everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #500
So, for the beginning I simply collapsed all the enum cases into a single "Other" case which has the representations of
eyre::Reportwhich is fairly compact from a memory usage standpoint.That will drop the stack usage of errors down significantly (by at least 4x).
I'm still not convinced whether this is the correct solution.