Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower dependency count #533

Merged
merged 9 commits into from
May 12, 2024
Merged

Lower dependency count #533

merged 9 commits into from
May 12, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented May 11, 2024

This PR just gets rid of some dependencies across the workspace to slim down the gigantic dependency tree.

Open question:

@aumetra
Copy link
Member Author

aumetra commented May 11, 2024

We are removing OpenTelemetry for now :(
Would prefer not to have to do this, but tonic just pulls in so many duplicate dependencies..

@aumetra
Copy link
Member Author

aumetra commented May 11, 2024

Actually, I have an idea.. this will be hacky.

@aumetra
Copy link
Member Author

aumetra commented May 11, 2024

Okay, that should be fine. Patched every OpenTelemetry dependency and the tonic dependency.. geez.

@aumetra aumetra enabled auto-merge (squash) May 12, 2024 17:26
@aumetra aumetra merged commit dd949ab into main May 12, 2024
17 of 18 checks passed
@aumetra aumetra deleted the less-deps branch May 12, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant