Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation based on code in FuelJson.kt #678

Merged
merged 1 commit into from
Aug 18, 2019

Conversation

aj-65
Copy link

@aj-65 aj-65 commented Aug 18, 2019

Description

I was a little confused when my code would compile with Result but saw Result in FuelJson.kt

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #678 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #678   +/-   ##
=========================================
  Coverage     71.32%   71.32%           
  Complexity      296      296           
=========================================
  Files            58       58           
  Lines          1496     1496           
  Branches        194      194           
=========================================
  Hits           1067     1067           
  Misses          334      334           
  Partials         95       95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db62aec...8150439. Read the comment docs.

@kittinunf
Copy link
Owner

Ah, it was a typo in the documentation. Thanks for fixing it for us. 👏

@kittinunf kittinunf merged commit 5b089fb into kittinunf:master Aug 18, 2019
@aj-65 aj-65 deleted the patch-1 branch August 18, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants