feat(php): add default !name if exception name couldnt be parsed

kkoomen · Oct 8, 2020 · 29a269c · 29a269c
1 parent dced707
commit 29a269c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/parsers/php.service.ts b/src/parsers/php.service.ts
@@ -240,12 +240,18 @@ export class PhpParserService
 
   private parseExceptions(node: SyntaxNode) {
     if (node.type === 'throw_statement') {
-      const exceptionName = node.children
+      const exception: Record<string, any> = { name: null };
+
+      const name = node.children
         .filter((n: SyntaxNode) => n.type === 'object_creation_expression')
         .shift()
         ?.children.filter((n: SyntaxNode) => n.type === 'qualified_name')
         .shift()?.text;
-      this.result.exceptions.push({ name: exceptionName || null });
+      if (name) {
+        exception.name = name;
+      }
+
+      this.result.exceptions.push(exception);
     }
 
     if (node.childCount > 0) {

diff --git a/test/filetypes/php/functions.vader b/test/filetypes/php/functions.vader
@@ -117,7 +117,8 @@ Expect php (generated comment with @param and @return tags):
 Given php (function with exceptions being raised in the body):
   <?php
   function test() {
-    throw new FirstException('Foo');
+    $err = new FirstException('Foo');
+    throw $err;
     throw new SecondException('Bar');
   }
 
@@ -130,12 +131,13 @@ Expect php (generated comment with @param, @throws and @return tags):
   /**
    * [TODO:description]
    *
-   * @throws FirstException [TODO:description]
+   * @throws [TODO:name] [TODO:description]
    * @throws SecondException [TODO:description]
    *
    * @return [TODO:type] [TODO:description]
    */
   function test() {
-    throw new FirstException('Foo');
+    $err = new FirstException('Foo');
+    throw $err;
     throw new SecondException('Bar');
   }