fix(typescript): exclude member expressions that dont have a function…

… value

helper/src/typescript/parser.rs

@@ -80,7 +80,14 @@ impl<'a> TypescriptParser<'a> {
                     "generator_function_declaration" |
                     "method_definition" => Some(self.parse_function(&child_node)),
 
-                    "member_expression" => Some(self.parse_member_expression(&child_node)),
+                    "member_expression" => {
+                        let tokens = self.parse_member_expression(&child_node).unwrap();
+                        if tokens.is_empty() {
+                            None
+                        } else {
+                            Some(Ok(tokens))
+                        }
+                    },
 
                     "class" | "class_declaration" => Some(self.parse_class(&child_node)),
 
@@ -169,6 +176,10 @@ impl<'a> TypescriptParser<'a> {
             }
         }
 
+        if tokens.get("function_name").is_none() {
+            return Ok(Map::new());
+        }
+
         if let Some(parent) = node.parent() {
             let func_node = parent.children(&mut parent.walk()).last();
             match self.parse_function(&func_node.unwrap()) {

scripts/run-vader-tests.sh

@@ -22,8 +22,6 @@ function filter-vader-output() {
   local force_echo=0
 
   while read -r; do
-    echo "$REPLY"
-
     # Search for the first Vader output line.
     if ((!hit_first_vader_line)); then
       if [[ "$REPLY" = *'Starting Vader:'* ]]; then

test/filetypes/javascript/functions.vader

@@ -447,15 +447,3 @@ Expect javascript (generated comments with a description, @param and @returns ta
    * @returns [TODO:description]
    */
   function foo(a, b: str, c = 3, d: int = 5): Promise<int> {}
-
-# ==============================================================================
-# Function calls that should not generate documentation
-# ==============================================================================
-Given javascript (function call):
-  AdminPermissionModel.create(item); 
-
-Do (trigger doge):
-  \<C-d>
-
-Expect javascript (to not have generated a docblock):
-  AdminPermissionModel.create(item); 

test/filetypes/javascript/ignored-expressions.vader

@@ -0,0 +1,26 @@
+# ==============================================================================
+# Function calls that should not generate documentation
+# ==============================================================================
+Given javascript (function call):
+  AdminPermissionModel.create(item);
+
+Do (trigger doge):
+  \<C-d>
+
+Expect javascript (to not have generated a docblock):
+  AdminPermissionModel.create(item);
+
+# ==============================================================================
+# Member expressions with no function_name
+# ==============================================================================
+Given javascript (member expression with no function name):
+  class Foo {}
+  Foo.propTypes = {};
+
+Do (trigger doge):
+  :2\<CR>
+  \<C-d>
+
+Expect javascript (to not have generated a docblock):
+  class Foo {}
+  Foo.propTypes = {};