Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh-script is using bash specifics while using sh in the hashbang #160

Closed
jerri opened this issue Nov 17, 2020 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@jerri
Copy link

jerri commented Nov 17, 2020

Updating vim-doge today on my computer led to the following errors

> ./scripts/install.sh
./scripts/install.sh: 17: [[: not found
/usr/bin/curl
./scripts/install.sh: 24: [[: not found
./scripts/install.sh: 31: [[: not found
./scripts/install.sh: 33: [[: not found
vim-doge does not support Windows yet

I am on Ubuntu here. I think the problem is related to sh being linked to dash on this computer, whereas the script used bash-extensions that dash does not support. I would suggest to either change the first line of the script to #!/usr/bin/env bash, or not use [[ in the script.

To Reproduce

Executing the script on a linux system that differentiates between sh and bash will lead to an error.

@jerri jerri added the bug Something isn't working label Nov 17, 2020
@kkoomen
Copy link
Owner

kkoomen commented Nov 17, 2020

That's a problem that happened due to the merge from yesterday. We decided to use sh as it's installed on almost every system. We can't guarantee bash is installed in all systems. I'll make it compatible with dash.

@iFork
Copy link

iFork commented Nov 17, 2020

@kkoomen - fix does not affect line 33 elif [[ $OS == 'Linux' ]]; then which still gives error. Please fix that line, too.

@kkoomen
Copy link
Owner

kkoomen commented Nov 17, 2020

This bug has been fixed and released in v3.5.4.

Feel free to submit any new issues if you experience any unwanted behavior in the future. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants