Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce linter for Typescript code #32

Closed
aliok opened this issue Feb 7, 2024 · 8 comments
Closed

Introduce linter for Typescript code #32

aliok opened this issue Feb 7, 2024 · 8 comments
Assignees
@ahmetcihank
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aliok
Copy link
Member

aliok commented Feb 7, 2024 •
edited
Loading

Typescript code is not linted currently.

Notes:

  • We already have lint scripts in package.json:

backstage-plugins/backstage/package.json

Lines 22 to 23 in 84b0e1c

"lint": "backstage-cli repo lint --since origin/main",
"lint:all": "backstage-cli repo lint",

So, we should have a separate linter action that is to be run in every PR AND we should also run the linter in the release actions as we double check everything when we release.
@aliok aliok added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 7, 2024
@VamshiReddy02
Copy link

Can I work on this issue?

@Leo6Leo
Copy link
Contributor

Leo6Leo commented Feb 20, 2024

/assign @VamshiReddy02

@ahmetcihank
Copy link
Contributor

/assign

@ahmetcihank
Copy link
Contributor

I am intentioanally breaking lint ; in order to test yarn backstage-cli repo lint --since origin/main script .. No matter how many times i tried, i am getting successfull lint builld.. This one is yarn backstage-cli repo lint, is checking lint for all the project .. @aliok

@aliok
Copy link
Member Author

aliok commented Mar 14, 2024

@ahmetcihank let's start with using lint:all(backstage-cli repo lint)? If we get answers from Backstage community about the --since origin/main part and understand why it isn't working, we can switch using that later on.

What do you think?

@ahmetcihank
Copy link
Contributor

@aliok sounds good, thanks a lot. I am assuming there is something about packages , which i couldn't figure out .

ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 14, 2024
@ahmetcihank
linting actions added in pr&release steps (knative-extensions#32)
070dac7
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 14, 2024
@ahmetcihank
fixed action file (knative-extensions#32)
3832503
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 14, 2024
@ahmetcihank
token added (knative-extensions#32)
2aabe9f
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 14, 2024
@ahmetcihank
fixed action file (knative-extensions#32)
fe57699
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 14, 2024
@ahmetcihank
fixed action file (knative-extensions#32)
bb7877c
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 14, 2024
@ahmetcihank
fixed action file (knative-extensions#32)
791dc4a
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 14, 2024
@ahmetcihank
fixed action file (knative-extensions#32)
560ac46
@ahmetcihank ahmetcihank mentioned this issue Mar 14, 2024
Merged
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 15, 2024
@ahmetcihank
added working directory (knative-extensions#32)
1a46f4d
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 15, 2024
@ahmetcihank
fixed path (knative-extensions#32)
0f29cd4
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 15, 2024
@ahmetcihank
fixed path (knative-extensions#32)
fb58896
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 15, 2024
@ahmetcihank
fixed path (knative-extensions#32)
2342591
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 15, 2024
@ahmetcihank
checkout added (knative-extensions#32)
7a21b10
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 15, 2024
@ahmetcihank
dependency action added (knative-extensions#32)
990a6d3
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 15, 2024
@ahmetcihank
fixed path (knative-extensions#32)
1076d58
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 15, 2024
@ahmetcihank
checkout added (knative-extensions#32)
828a973
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 15, 2024
@ahmetcihank
dependency action added (knative-extensions#32)
e7efea1
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 16, 2024
@ahmetcihank
refactoring for lint issues (knative-extensions#32)
034b90a
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 16, 2024
@ahmetcihank
refactoring for lint issues (knative-extensions#32)
d99da01
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 16, 2024
@ahmetcihank
refactoring for lint issues (knative-extensions#32)
185ba67
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 16, 2024
@ahmetcihank
revert package json changes (knative-extensions#32)
61c26f0
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 27, 2024
@ahmetcihank
fixed linting issues (knative-extensions#32)
a554c8c
ahmetcihank added a commit to ahmetcihank/backstage-plugins that referenced this issue Mar 30, 2024
@ahmetcihank
fixed linting (knative-extensions#32)
92d409a
knative-prow bot pushed a commit that referenced this issue Apr 1, 2024
@ahmetcihank
linting actions added (#48)
c42d396 
* added catalog api pagination(#28)

* added test case & initialized cursor(#28)

* changed cursor into local variable(#28)

* introduced query limit constant & fixed tests (#28)

* test case added (#28)

* pagination test case extended

* linting actions added in pr&release steps (#32)

* fixed path (#32)

* checkout added (#32)

* dependency action added (#32)

* refactoring for lint issues (#32)

* refactoring for lint issues (#32)

* revert package json changes (#32)

* fixed linting issues (#32)

* fixed linting (#32)
@aliok
Copy link
Member Author

aliok commented Apr 1, 2024

/close
Fixed by #48

@knative-prow knative-prow bot closed this as completed Apr 1, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 1, 2024

@aliok: Closing this issue.

In response to this:

/close
Fixed by #48

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmetcihank ahmetcihank

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aliok @Leo6Leo @ahmetcihank @VamshiReddy02