Do not de-duplicate event types #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Ali Ok <aliok@redhat.com>
|
@aliok: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow
bot
added
approved
Closed
Signed-off-by: Ali Ok <aliok@redhat.com>
knative-prow
bot
added
size/XL
aliok
force-pushed
the
2023-12-20-no-dedupe
branch
from
55ac653
to
91ceacb
Compare
knative-prow
bot
added
size/L
aliok
force-pushed
the
2023-12-20-no-dedupe
branch
from
91ceacb
to
50dc626
Compare
knative-prow
bot
added
size/XL
Signed-off-by: Ali Ok <aliok@redhat.com>
aliok
force-pushed
the
2023-12-20-no-dedupe
branch
from
50dc626
to
ca3456e
Compare
knative-prow
bot
added
size/L
Signed-off-by: Ali Ok <aliok@redhat.com>
aliok
force-pushed
the
2023-12-20-no-dedupe
branch
from
f90aa2b
to
9ee441e
Compare
|
Is this related to the grouping we discussed? |
|
No, this gets rid of deduplication. I will experiment with grouping later. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind
Fixes #
Release Note
Docs