Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify that scaledobjects have no authenticationref when it is empty #3944

Conversation

Cali0707
Copy link
Member

As a follow up on #3939 this PR adds a regression test to prevent this issue from coming back

Proposed Changes

  • Verify that the scaledobject created by a KafkaSource's consumergroup does not have an authentication ref unless it needs to

…empty

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added area/test size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 21, 2024
@Cali0707
Copy link
Member Author

/cc @pierDipi @creydr @maschmid

@Cali0707
Copy link
Member Author

@pierDipi should we backport this along with the fixes or is it fine for this test to only be in main for now?

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024
Copy link

knative-prow bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/test reconciler-tests-namespaced-broker

@pierDipi
Copy link
Member

Yes, @Cali0707

@knative-prow knative-prow bot merged commit b5bb25a into knative-extensions:main Jun 25, 2024
35 checks passed
@Cali0707
Copy link
Member Author

/cherry-pick release-1.14

@Cali0707
Copy link
Member Author

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@Cali0707: new pull request created: #3949

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@Cali0707: #3944 failed to apply on top of branch "release-1.13":

Applying: test: verify that scaledobjects have no authenticationref when it is empty
Using index info to reconstruct a base tree...
A	test/rekt/features/keda_scaling.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/rekt/features/keda_scaling.go deleted in HEAD and modified in test: verify that scaledobjects have no authenticationref when it is empty. Version test: verify that scaledobjects have no authenticationref when it is empty of test/rekt/features/keda_scaling.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test: verify that scaledobjects have no authenticationref when it is empty
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Cali0707 added a commit to Cali0707/eventing-kafka-broker that referenced this pull request Jun 27, 2024
Cali0707 added a commit to Cali0707/eventing-kafka-broker that referenced this pull request Jun 27, 2024
openshift-merge-bot bot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Jul 8, 2024
…e is an actual value to reference (knative-extensions#3941) (#1119)

* fix: only add triggerAuth to scaled objects when there is an actual value to reference (knative-extensions#3941)

Signed-off-by: Calum Murray <cmurray@redhat.com>

* test: verify that scaledobjects have no authenticationref when it is empty (knative-extensions#3944)

Signed-off-by: Calum Murray <cmurray@redhat.com>

---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants