-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: verify that scaledobjects have no authenticationref when it is empty #3944
test: verify that scaledobjects have no authenticationref when it is empty #3944
Conversation
…empty Signed-off-by: Calum Murray <cmurray@redhat.com>
@pierDipi should we backport this along with the fixes or is it fine for this test to only be in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test reconciler-tests-namespaced-broker |
Yes, @Cali0707 |
/cherry-pick release-1.14 |
/cherry-pick release-1.13 |
@Cali0707: new pull request created: #3949 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Cali0707: #3944 failed to apply on top of branch "release-1.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…empty (knative-extensions#3944) Signed-off-by: Calum Murray <cmurray@redhat.com>
…empty (knative-extensions#3944) Signed-off-by: Calum Murray <cmurray@redhat.com>
…e is an actual value to reference (knative-extensions#3941) (#1119) * fix: only add triggerAuth to scaled objects when there is an actual value to reference (knative-extensions#3941) Signed-off-by: Calum Murray <cmurray@redhat.com> * test: verify that scaledobjects have no authenticationref when it is empty (knative-extensions#3944) Signed-off-by: Calum Murray <cmurray@redhat.com> --------- Signed-off-by: Calum Murray <cmurray@redhat.com>
As a follow up on #3939 this PR adds a regression test to prevent this issue from coming back
Proposed Changes