Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the name value for metrics tags to the correct top-level resource #4120

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Set the name value for metrics tags to the correct top-level resource #4120

merged 1 commit into from
Oct 1, 2024

Conversation

pierDipi
Copy link
Member

Previously to v2, we were setting name to the Broker or Channel name of the resource.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/control-plane labels Sep 25, 2024
@pierDipi
Set the name value for metrics tags to the correct top-level resource
16393a7 
Previously to v2, we were setting `name` to the Broker or Channel
name of the resource.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi mentioned this pull request Sep 25, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.41463% with 15 lines in your changes missing coverage. Please review.

Project coverage is 48.51%. Comparing base (f9f799c) to head (16393a7).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
control-plane/pkg/reconciler/consumer/consumer.go 40.90% 10 Missing and 3 partials ⚠️
...ls/kafka/eventing/v1alpha1/consumer_group_types.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4120      +/-   ##
==========================================
+ Coverage   48.47%   48.51%   +0.03%     
==========================================
  Files         244      244              
  Lines       14888    14928      +40     
==========================================
+ Hits         7217     7242      +25     
- Misses       6943     6955      +12     
- Partials      728      731       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi pierDipi mentioned this pull request Sep 25, 2024
Merged
matzew
matzew reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/retest-required

@pierDipi
Copy link
Member Author

/test integration-tests

creydr
creydr reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@creydr
Copy link
Contributor

creydr commented Sep 30, 2024

/test reconciler-tests-namespaced-broker

1 similar comment
@pierDipi
Copy link
Member Author

pierDipi commented Oct 1, 2024

/test reconciler-tests-namespaced-broker

@knative-prow knative-prow bot merged commit 720a336 into knative-extensions:main Oct 1, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@creydr creydr creydr left review comments

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@matzew matzew

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @creydr @matzew