Add support for git commit sha #587
Conversation
copying solution from tektoncd pipeline: tektoncd/pipeline#555 Credit to @dibbles on the original PR
There was a problem hiding this comment.
@shashwathi: 0 warnings.
In response to this:
Copying solution from tektoncd pipeline: tektoncd/pipeline#555
Credit to @dibbles on the original PRFixes #212
Release Note
Include support for git source with commit ID for revision
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
/lgtm |
- Previous e2e test failed as namespace did not have default SA. Now the test setup verifies this exists
|
@imjasonh : Updated e2e test setup to check for SA creation and address bot comment on copyright year |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shashwathi, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add support for git commit sha copying solution from tektoncd pipeline: tektoncd/pipeline#555 Credit to @dibbles on the original PR * Add verification of default SA creation in e2e - Previous e2e test failed as namespace did not have default SA. Now the test setup verifies this exists
* Add support for git commit sha copying solution from tektoncd pipeline: tektoncd/pipeline#555 Credit to @dibbles on the original PR * Add verification of default SA creation in e2e - Previous e2e test failed as namespace did not have default SA. Now the test setup verifies this exists
Copying solution from tektoncd pipeline: tektoncd/pipeline#555
Credit to @dibbles on the original PR
Fixes #212
Release Note