Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build API docs for 0.17 #2763

Merged
merged 9 commits into from
Aug 20, 2020
Merged

build API docs for 0.17 #2763

merged 9 commits into from
Aug 20, 2020

Conversation

RichieEscarez
Copy link
Contributor

Update API ref docs using new 0.17 knative components

https://github.com/knative/docs/tree/master/docs/reference#updating-api-reference-docs-for-knative-maintainers

cd hack

KNATIVE_SERVING_COMMIT=v0.17.0 KNATIVE_EVENTING_COMMIT=v0.17.0 KNATIVE_EVENTING_CONTRIB_COMMIT=v0.17.0 ./gen-api-reference-docs.sh

@RichieEscarez RichieEscarez added this to the v0.17.0 milestone Aug 19, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 19, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 19, 2020
@RichieEscarez @mattmoor
Update docs/reference/serving.md
a0dac20 
Co-authored-by: Matt Moore <mattmoor@vmware.com>
@RichieEscarez @mattmoor
Update docs/reference/serving.md
24e5c03 
Co-authored-by: Matt Moore <mattmoor@vmware.com>
ellenevans
ellenevans approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@ellenevans ellenevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@RichieEscarez @mattmoor
Update docs/reference/serving.md
9896a26 
Co-authored-by: Matt Moore <mattmoor@vmware.com>
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ellenevans, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ellenevans, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RichieEscarez @mattmoor
Update docs/reference/serving.md
c85cdda 
Co-authored-by: Matt Moore <mattmoor@vmware.com>
@RichieEscarez @mattmoor
Update docs/reference/serving.md
f3b9d80 
Co-authored-by: Matt Moore <mattmoor@vmware.com>
@RichieEscarez @mattmoor
Update docs/reference/serving.md
2da87bd 
Co-authored-by: Matt Moore <mattmoor@vmware.com>
@RichieEscarez @mattmoor
Update docs/reference/serving.md
9862984 
Co-authored-by: Matt Moore <mattmoor@vmware.com>
@RichieEscarez @mattmoor
Update docs/reference/serving.md
bdf138b 
Co-authored-by: Matt Moore <mattmoor@vmware.com>
@RichieEscarez
Copy link
Contributor Author

all suggestions applied (i wonder if we can get the script to remove all the whitespace automatically?)

just need an /lgtm to merge

@RichieEscarez RichieEscarez mentioned this pull request Aug 20, 2020
Merged
@ellenevans
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@knative-prow-robot knative-prow-robot merged commit ee28750 into knative:master Aug 20, 2020
@RichieEscarez RichieEscarez deleted the 0.17apidocs branch March 8, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@ellenevans ellenevans ellenevans approved these changes

@jonatasbaldin jonatasbaldin Awaiting requested review from jonatasbaldin

@samodell samodell Awaiting requested review from samodell

Assignees

@ellenevans ellenevans

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/eventing kind/serving lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RichieEscarez @knative-prow-robot @ellenevans @mattmoor @googlebot