State prerequisites in README.md explicitly #30
Conversation
|
Hi @aliok. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -46,6 +46,17 @@ EOF | |||
| Please refer to [Building the Operator Image](#building-the-operator-image) to | |||
| build your own image. | |||
|
|
|||
| ## Prerequisites | |||
There was a problem hiding this comment.
This header was referenced above ("...Please make sure the [prerequisites](#Prerequisites) are installed first...")
| kubectl get eventings.operator.knative.dev -oyaml | ||
| kubectl get eventing -oyaml | ||
| kubectl get eventings.operator.knative.dev | ||
| kubectl get eventing | ||
| kubectl get ke | ||
| ``` |
There was a problem hiding this comment.
Added ke as well.
Got rid of -oyaml as it proves no point here.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it.. |
|
/assign @n3wscott |
|
@aliok Plz make sure you sign the CLA. |
|
@houshengbo I've already signed it. Let me push force and remove @mattmoor co-authored commit. Maybe there's a problem with his CLA. UPDATE: did that and it is fixed! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| * [`ko`](https://github.com/google/ko) | ||
|
|
||
| Install `ko` with the following command, if it is not available on your machine: | ||
| ``` |
There was a problem hiding this comment.
README.md:54: MD031 Fenced code blocks should be surrounded by blank lines
|
@aliok Would u minding changing one more time based on the comments from the build job?? |
|
cc @houshengbo fixed the test failures |
|
/ok-to-test |
State prerequisites in README.md explicitly.
Comments inline.